Patchwork Define extern sub_cp unconditionally

login
register
mail settings
Submitter Ingo Brückl
Date Jan. 9, 2012, 12:18 p.m.
Message ID <4f0adfad.368777f8.bm000@wupperonline.de>
Download mbox | patch
Permalink /patch/14953/
State New
Headers show

Comments

Ingo Brückl - Jan. 9, 2012, 12:18 p.m.
I'm not quite sure how declaration and definition of a global variable only
needed for particular CONFIGs are supposed to be done, but I could remove
some #ifdefs in the GUI code if unconditionally declared extern sub_cp would
be defined unconditionally as well.

Ingo

Patch

Index: sub/subreader.c
===================================================================
--- sub/subreader.c	(revision 34533)
+++ sub/subreader.c	(working copy)
@@ -50,8 +50,8 @@ 
 
 #ifdef CONFIG_ICONV
 #include <iconv.h>
+#endif
 char *sub_cp=NULL;
-#endif
 #ifdef CONFIG_FRIBIDI
 #include <fribidi/fribidi.h>
 char *fribidi_charset = NULL;   ///character set that will be passed to FriBiDi