| Message ID | 1320412690-74862-2-git-send-email-martin@martin.st |
|---|---|
| State | Committed |
| Commit | 3607ed70d5ad44b6614cac27f9c833d24626635e |
| Headers | show |
On 11/4/11 6:18 AM, Martin Storsjö wrote: > To the best of my knowledge, none of these should be needed. > --- > All except bktr.c and v4l.c have been testcompiled, but I don't > see any functions in those files that would require strings.h. > any bsd guy willing to test compile bktr? Patch looks ok though lu
On Fri, 4 Nov 2011, Luca Barbato wrote: > On 11/4/11 6:18 AM, Martin Storsjö wrote: >> To the best of my knowledge, none of these should be needed. >> --- >> All except bktr.c and v4l.c have been testcompiled, but I don't >> see any functions in those files that would require strings.h. >> > > any bsd guy willing to test compile bktr? Testcompiled bktr on FreeBSD 8.0 and v4l on a machine old enough to have linux/videodev.h, both work fine. // Martin
On 11/4/11 7:56 AM, Martin Storsjö wrote: > On Fri, 4 Nov 2011, Luca Barbato wrote: > >> On 11/4/11 6:18 AM, Martin Storsjö wrote: >>> To the best of my knowledge, none of these should be needed. >>> --- >>> All except bktr.c and v4l.c have been testcompiled, but I don't >>> see any functions in those files that would require strings.h. >>> >> >> any bsd guy willing to test compile bktr? > > Testcompiled bktr on FreeBSD 8.0 and v4l on a machine old enough to have > linux/videodev.h, both work fine. > Patch ok I guess. lu
diff --git a/libavdevice/bktr.c b/libavdevice/bktr.c index 8dd4e3a..1a8562c 100644 --- a/libavdevice/bktr.c +++ b/libavdevice/bktr.c @@ -47,7 +47,6 @@ #include <sys/time.h> #include <signal.h> #include <stdint.h> -#include <strings.h> typedef struct { AVClass *class; diff --git a/libavdevice/dv1394.c b/libavdevice/dv1394.c index 1ac9a81..69e59ec 100644 --- a/libavdevice/dv1394.c +++ b/libavdevice/dv1394.c @@ -28,7 +28,6 @@ #include <sys/mman.h> #include <sys/time.h> #include <time.h> -#include <strings.h> #include "libavutil/log.h" #include "libavutil/opt.h" diff --git a/libavdevice/v4l.c b/libavdevice/v4l.c index 5fc91d3..d848e2b 100644 --- a/libavdevice/v4l.c +++ b/libavdevice/v4l.c @@ -39,7 +39,6 @@ #define _LINUX_TIME_H 1 #include <linux/videodev.h> #include <time.h> -#include <strings.h> typedef struct { AVClass *class; diff --git a/libavformat/os_support.c b/libavformat/os_support.c index c6715f3..889a005 100644 --- a/libavformat/os_support.c +++ b/libavformat/os_support.c @@ -71,7 +71,6 @@ int ff_win32_open(const char *filename_utf8, int oflag, int pmode) #if !HAVE_INET_ATON #include <stdlib.h> -#include <strings.h> int ff_inet_aton (const char * str, struct in_addr * add) { diff --git a/libavformat/rtpdec_latm.c b/libavformat/rtpdec_latm.c index 42317a9..96f4e83 100644 --- a/libavformat/rtpdec_latm.c +++ b/libavformat/rtpdec_latm.c @@ -23,7 +23,6 @@ #include "internal.h" #include "libavutil/avstring.h" #include "libavcodec/get_bits.h" -#include <strings.h> struct PayloadContext { AVIOContext *dyn_buf; diff --git a/libavformat/wtv.c b/libavformat/wtv.c index cdb5c49..c3bc083 100644 --- a/libavformat/wtv.c +++ b/libavformat/wtv.c @@ -33,7 +33,6 @@ #include "riff.h" #include "asf.h" #include "mpegts.h" -#include <strings.h> /* Macros for formating GUIDs */ #define PRI_GUID \ diff --git a/libavutil/dict.c b/libavutil/dict.c index 3ea7e55..cb5f7b1 100644 --- a/libavutil/dict.c +++ b/libavutil/dict.c @@ -18,7 +18,6 @@ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ -#include <strings.h> #include "avstring.h" #include "dict.h" #include "internal.h"