http: Make sure proxyauth is initialized

Message ID 1322731528-62447-1-git-send-email-martin@martin.st
State Committed
Commit abe20c59b93426958624e16e89b24e0c0b43f370
Headers show

Commit Message

Martin Storsjö Dec. 1, 2011, 9:25 a.m.
This string will be passed to ff_http_auth_create_response
even if no proxy is used, resulting in reading uninitialized
memory.
---
 libavformat/http.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Luca Barbato Dec. 1, 2011, 9:59 a.m. | #1
On 01/12/11 10:25, Martin Storsjö wrote:
> This string will be passed to ff_http_auth_create_response
> even if no proxy is used, resulting in reading uninitialized
> memory.

Ok.

Patch

diff --git a/libavformat/http.c b/libavformat/http.c
index 63cfecd..a9b4d5a 100644
--- a/libavformat/http.c
+++ b/libavformat/http.c
@@ -90,7 +90,7 @@  static int http_open_cnx(URLContext *h)
 {
     const char *path, *proxy_path, *lower_proto = "tcp", *local_path;
     char hostname[1024], hoststr[1024], proto[10];
-    char auth[1024], proxyauth[1024];
+    char auth[1024], proxyauth[1024] = "";
     char path1[1024];
     char buf[1024], urlbuf[1024];
     int port, use_proxy, err, location_changed = 0, redirects = 0;