wmaenc: require a large enough output buffer to prevent overwrites

Message ID 20120303232520.AB1495DAF9@aruru.libav.org
State New
Headers show

Commit Message

Janne Grunau March 3, 2012, 11:25 p.m.
Module: libav
Branch: master
Commit: dfc4fdedf8cfc56a505579b1f2c1c5efbce4b97e

Author:    Justin Ruggles <justin.ruggles@gmail.com>
Committer: Justin Ruggles <justin.ruggles@gmail.com>
Date:      Fri Mar  2 16:33:33 2012 -0500

wmaenc: require a large enough output buffer to prevent overwrites

The maximum theoretical frame size is around 17000 bytes. Although in
practice it will generally be much smaller, we require a larger buffer
just to be safe.

CC: libav-stable@libav.org

---

 libavcodec/wmaenc.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

Patch

diff --git a/libavcodec/wmaenc.c b/libavcodec/wmaenc.c
index 99544c0..5135b98 100644
--- a/libavcodec/wmaenc.c
+++ b/libavcodec/wmaenc.c
@@ -365,6 +365,11 @@  static int encode_superframe(AVCodecContext *avctx,
         }
     }
 
+    if (buf_size < 2 * MAX_CODED_SUPERFRAME_SIZE) {
+        av_log(avctx, AV_LOG_ERROR, "output buffer size is too small\n");
+        return AVERROR(EINVAL);
+    }
+
 #if 1
     total_gain= 128;
     for(i=64; i; i>>=1){