libvo-* Mention VisualOn in the new codecs' long names

Message ID 1302721717-88403-1-git-send-email-martin@martin.st
State Superseded
Headers show

Commit Message

Martin Storsjö April 13, 2011, 7:08 p.m.
From: Carl Eugen Hoyos <cehoyos@ag.or.at>

---
 libavcodec/libvo-aacenc.c   |    2 +-
 libavcodec/libvo-amrwbenc.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Luca Barbato April 13, 2011, 7:15 p.m. | #1
On 04/13/2011 09:08 PM, Martin Storsjö wrote:
> From: Carl Eugen Hoyos <cehoyos@ag.or.at>

Call them Google/VisualOn since VisualOn ones seems to be quite
different feature wise.

lu
Ronald Bultje April 13, 2011, 7:15 p.m. | #2
Hi,

On Wed, Apr 13, 2011 at 3:08 PM, Martin Storsjö <martin@martin.st> wrote:
> From: Carl Eugen Hoyos <cehoyos@ag.or.at>
>
> ---
>  libavcodec/libvo-aacenc.c   |    2 +-
>  libavcodec/libvo-amrwbenc.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/libvo-aacenc.c b/libavcodec/libvo-aacenc.c
> index 7006d78..0321e77 100644
> --- a/libavcodec/libvo-aacenc.c
> +++ b/libavcodec/libvo-aacenc.c
> @@ -125,6 +125,6 @@ AVCodec ff_libvo_aacenc_encoder = {
>     aac_encode_close,
>     NULL,
>     .sample_fmts = (const enum AVSampleFormat[]){AV_SAMPLE_FMT_S16,AV_SAMPLE_FMT_NONE},
> -    .long_name = NULL_IF_CONFIG_SMALL("libvo-aacenc AAC"),
> +    .long_name = NULL_IF_CONFIG_SMALL("VisualOn libvo-aacenc AAC"),

So .long_name is supposed to be a human-readable, UI-style name, right?

"libvo-aacenc" doesn't fit that description. I'd remove that part.

Ronald

Patch

diff --git a/libavcodec/libvo-aacenc.c b/libavcodec/libvo-aacenc.c
index 7006d78..0321e77 100644
--- a/libavcodec/libvo-aacenc.c
+++ b/libavcodec/libvo-aacenc.c
@@ -125,6 +125,6 @@  AVCodec ff_libvo_aacenc_encoder = {
     aac_encode_close,
     NULL,
     .sample_fmts = (const enum AVSampleFormat[]){AV_SAMPLE_FMT_S16,AV_SAMPLE_FMT_NONE},
-    .long_name = NULL_IF_CONFIG_SMALL("libvo-aacenc AAC"),
+    .long_name = NULL_IF_CONFIG_SMALL("VisualOn libvo-aacenc AAC"),
 };
 
diff --git a/libavcodec/libvo-amrwbenc.c b/libavcodec/libvo-amrwbenc.c
index 162ef01..64f19b9 100644
--- a/libavcodec/libvo-amrwbenc.c
+++ b/libavcodec/libvo-amrwbenc.c
@@ -117,7 +117,7 @@  AVCodec ff_libvo_amrwbenc_encoder = {
     amr_wb_encode_close,
     NULL,
     .sample_fmts = (const enum AVSampleFormat[]){AV_SAMPLE_FMT_S16,AV_SAMPLE_FMT_NONE},
-    .long_name = NULL_IF_CONFIG_SMALL("libvo-amrwbenc Adaptive Multi-Rate "
+    .long_name = NULL_IF_CONFIG_SMALL("VisualOn libvo-amrwbenc Adaptive Multi-Rate "
                                       "(AMR) Wide-Band"),
 };