applehttp: Don't export variant_bitrate if it isn't known

Message ID 1303665831-17469-1-git-send-email-martin@martin.st
State Committed
Commit 5f85d49b6889b9a2ecd18695fe52c5c9b698a0e1
Headers show

Commit Message

Martin Storsjö April 24, 2011, 5:23 p.m.
If there are no variants, the total bitrate of the single
stream isn't known, and exporting variant_bitrate = 0 does
look weird, since there really aren't any variants.
---
 libavformat/applehttp.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

Comments

Ronald Bultje April 24, 2011, 6:07 p.m. | #1
Hi,

On Sun, Apr 24, 2011 at 1:23 PM, Martin Storsjö <martin@martin.st> wrote:
> If there are no variants, the total bitrate of the single
> stream isn't known, and exporting variant_bitrate = 0 does
> look weird, since there really aren't any variants.
> ---
>  libavformat/applehttp.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)

Yes, fine.

Ronald

Patch

diff --git a/libavformat/applehttp.c b/libavformat/applehttp.c
index 2e0e8a1..822d80b 100644
--- a/libavformat/applehttp.c
+++ b/libavformat/applehttp.c
@@ -505,7 +505,9 @@  static int applehttp_read_header(AVFormatContext *s, AVFormatParameters *ap)
                 goto fail;
             }
             avcodec_copy_context(st->codec, v->ctx->streams[j]->codec);
-            av_metadata_set2(&st->metadata, "variant_bitrate", bitrate_str, 0);
+            if (v->bandwidth)
+                av_metadata_set2(&st->metadata, "variant_bitrate", bitrate_str,
+                                 0);
         }
         stream_offset += v->ctx->nb_streams;
     }