[06/13] h264: remove clear_blocks call in threading init

Message ID 1364995179-98359-6-git-send-email-martin@martin.st
State Superseded
Headers show

Commit Message

Martin Storsjö April 3, 2013, 1:19 p.m.
From: "Ronald S. Bultje" <rsbultje@gmail.com>

---
 libavcodec/h264.c |    2 --
 1 file changed, 2 deletions(-)

Comments

Luca Barbato April 3, 2013, 1:39 p.m. | #1
On 03/04/13 15:19, Martin Storsjö wrote:
> From: "Ronald S. Bultje" <rsbultje@gmail.com>
> 
> ---
>  libavcodec/h264.c |    2 --
>  1 file changed, 2 deletions(-)

Would be nice adding why it is not needed anymore.
Martin Storsjö April 3, 2013, 2:05 p.m. | #2
On Wed, 3 Apr 2013, Luca Barbato wrote:

> On 03/04/13 15:19, Martin Storsjö wrote:
>> From: "Ronald S. Bultje" <rsbultje@gmail.com>
>> 
>> ---
>>  libavcodec/h264.c |    2 --
>>  1 file changed, 2 deletions(-)
>
> Would be nice adding why it is not needed anymore.

Actually, it is, this commit breaks threaded decoding. Will fix.

// Martin

Patch

diff --git a/libavcodec/h264.c b/libavcodec/h264.c
index 6721365..8d1af9f 100644
--- a/libavcodec/h264.c
+++ b/libavcodec/h264.c
@@ -1640,8 +1640,6 @@  static int decode_update_thread_context(AVCodecContext *dst,
 
         h->thread_context[0] = h;
 
-        h->dsp.clear_blocks(h->mb);
-        h->dsp.clear_blocks(h->mb + (24 * 16 << h->pixel_shift));
         h->context_initialized = 1;
     }