[02/11] riff: Add a mapping for VP6A

Message ID 1381320210-79941-2-git-send-email-martin@martin.st
State Committed
Commit a52b5a5a07b0d432f9bed90b6d56647f8d44fbce
Headers show

Commit Message

Martin Storsjö Oct. 9, 2013, 12:03 p.m.
This allows demuxing VP6A from F4V files.
---
Is it ok to add it here, or should it be added to some other list
more specific to the mov/f4v demuxer?
---
 libavformat/riff.c |    1 +
 1 file changed, 1 insertion(+)

Comments

Luca Barbato Oct. 9, 2013, 12:09 p.m. | #1
On 09/10/13 14:03, Martin Storsjö wrote:
> This allows demuxing VP6A from F4V files.
> ---
> Is it ok to add it here, or should it be added to some other list
> more specific to the mov/f4v demuxer?
> ---
>  libavformat/riff.c |    1 +
>  1 file changed, 1 insertion(+)
> 

Do we expect it to happen in avi and nut as well?

lu
Martin Storsjö Oct. 9, 2013, 12:24 p.m. | #2
On Wed, 9 Oct 2013, Luca Barbato wrote:

> On 09/10/13 14:03, Martin Storsjö wrote:
>> This allows demuxing VP6A from F4V files.
>> ---
>> Is it ok to add it here, or should it be added to some other list
>> more specific to the mov/f4v demuxer?
>> ---
>>  libavformat/riff.c |    1 +
>>  1 file changed, 1 insertion(+)
>> 
>
> Do we expect it to happen in avi and nut as well?

Not sure if it's plausible, but if you can end up with VP6F there I guess 
you can just as well end up with VP6A as well.

// Martin
Martin Storsjö Oct. 10, 2013, 7:44 a.m. | #3
On Wed, 9 Oct 2013, Martin Storsjö wrote:

> On Wed, 9 Oct 2013, Luca Barbato wrote:
>
>> On 09/10/13 14:03, Martin Storsjö wrote:
>>> This allows demuxing VP6A from F4V files.
>>> ---
>>> Is it ok to add it here, or should it be added to some other list
>>> more specific to the mov/f4v demuxer?
>>> ---
>>>  libavformat/riff.c |    1 +
>>>  1 file changed, 1 insertion(+)
>>> 
>>
>> Do we expect it to happen in avi and nut as well?
>
> Not sure if it's plausible, but if you can end up with VP6F there I guess 
> you can just as well end up with VP6A as well.

OK'd by Kostya on irc.

// Martin

Patch

diff --git a/libavformat/riff.c b/libavformat/riff.c
index 8216261..2668d19 100644
--- a/libavformat/riff.c
+++ b/libavformat/riff.c
@@ -228,6 +228,7 @@  const AVCodecTag ff_codec_bmp_tags[] = {
     { AV_CODEC_ID_VP6,          MKTAG('V', 'P', '6', '0') },
     { AV_CODEC_ID_VP6,          MKTAG('V', 'P', '6', '1') },
     { AV_CODEC_ID_VP6,          MKTAG('V', 'P', '6', '2') },
+    { AV_CODEC_ID_VP6A,         MKTAG('V', 'P', '6', 'A') },
     { AV_CODEC_ID_VP6F,         MKTAG('V', 'P', '6', 'F') },
     { AV_CODEC_ID_VP6F,         MKTAG('F', 'L', 'V', '4') },
     { AV_CODEC_ID_VP8,          MKTAG('V', 'P', '8', '0') },