[01/20] aarch64: do not add the optional ', lsl #0' for byte vectors

Message ID 1395664691-60544-1-git-send-email-martin@martin.st
State Not Applicable
Headers show

Commit Message

Martin Storsjö March 24, 2014, 12:37 p.m.
From: Janne Grunau <janne-libav@jannau.net>

Although it is allowed it does not make much sense since the immediate
is already 8bits.
---
 gas-preprocessor.pl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Martin Storsjö March 24, 2014, 12:38 p.m. | #1
On Mon, 24 Mar 2014, Martin Storsjo wrote:

> From: Janne Grunau <janne-libav@jannau.net>
>
> Although it is allowed it does not make much sense since the immediate
> is already 8bits.
> ---
> gas-preprocessor.pl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Sorry, this patch obviously already is applied.

// Martin
Janne Grunau March 24, 2014, 12:43 p.m. | #2
On 2014-03-24 14:37:52 +0200, Martin Storsjö wrote:
> From: Janne Grunau <janne-libav@jannau.net>
> 
> Although it is allowed it does not make much sense since the immediate
> is already 8bits.
> ---
>  gas-preprocessor.pl | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl
> index 914c41c..14a6309 100755
> --- a/gas-preprocessor.pl
> +++ b/gas-preprocessor.pl
> @@ -757,8 +757,8 @@ sub handle_serialized_line {
>          if ($line =~ /^\s*mov\s+(v\d[\.{}\[\]\w]+),\s*(v\d[\.{}\[\]\w]+)\b\s*$/) {
>              $line = "        orr $1, $2, $2\n";
>          }
> -        # movi 8, 16, 32 bit shifted variant, shift is optional
> -        if ($line =~ /^\s*movi\s+(v[0-3]?\d\.(?:2|4|8|16)[bhsBHS])\s*,\s*(#\w+)\b\s*$/) {
> +        # movi 16, 32 bit shifted variant, shift is optional
> +        if ($line =~ /^\s*movi\s+(v[0-3]?\d\.(?:2|4|8)[hsHS])\s*,\s*(#\w+)\b\s*$/) {
>              $line = "        movi $1, $2, lsl #0\n";
>          }
>          # Xcode 5 misses the alias uxtl replace it with the more general ushll

obviously ok, :)

Janne

Patch

diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl
index 914c41c..14a6309 100755
--- a/gas-preprocessor.pl
+++ b/gas-preprocessor.pl
@@ -757,8 +757,8 @@  sub handle_serialized_line {
         if ($line =~ /^\s*mov\s+(v\d[\.{}\[\]\w]+),\s*(v\d[\.{}\[\]\w]+)\b\s*$/) {
             $line = "        orr $1, $2, $2\n";
         }
-        # movi 8, 16, 32 bit shifted variant, shift is optional
-        if ($line =~ /^\s*movi\s+(v[0-3]?\d\.(?:2|4|8|16)[bhsBHS])\s*,\s*(#\w+)\b\s*$/) {
+        # movi 16, 32 bit shifted variant, shift is optional
+        if ($line =~ /^\s*movi\s+(v[0-3]?\d\.(?:2|4|8)[hsHS])\s*,\s*(#\w+)\b\s*$/) {
             $line = "        movi $1, $2, lsl #0\n";
         }
         # Xcode 5 misses the alias uxtl replace it with the more general ushll