[3/3] h261dec: Fix order of initialization

Message ID 1407627987-19291-3-git-send-email-stebbins@jetheaddev.com
State New
Headers show

Commit Message

John Stebbins Aug. 9, 2014, 11:46 p.m.
ff_MPV_common_init requires the frame dimensions which get parsed in
h261_decode_picture_header.
---
 libavcodec/h261dec.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

Patch

diff --git a/libavcodec/h261dec.c b/libavcodec/h261dec.c
index c3c3ff6..8c34bb5 100644
--- a/libavcodec/h261dec.c
+++ b/libavcodec/h261dec.c
@@ -581,12 +581,9 @@  static int h261_decode_frame(AVCodecContext *avctx, void *data,
 retry:
     init_get_bits(&s->gb, buf, buf_size * 8);
 
-    if (!s->context_initialized) {
+    if (!s->context_initialized)
         // we need the IDCT permutaton for reading a custom matrix
         ff_idct_common_init(s);
-        if (ff_MPV_common_init(s) < 0)
-            return -1;
-    }
 
     ret = h261_decode_picture_header(h);
 
@@ -602,6 +599,11 @@  retry:
         ff_MPV_common_end(s);
         s->parse_context = pc;
     }
+
+    if (!s->context_initialized)
+        if ((ret = ff_MPV_common_init(s)) < 0)
+            return ret;
+
     if (!s->context_initialized) {
         ret = ff_set_dimensions(avctx, s->width, s->height);
         if (ret < 0)