lavfi: clean memory on error in ADD_FORMAT()

Message ID 20141121124721.A2E945DCA4@aruru.libav.org
State New
Headers show

Commit Message

Janne Grunau Nov. 21, 2014, 12:47 p.m.
Module: libav
Branch: master
Commit: 863ee8a855b8ce27ffef41479eb66da58763faed

Author:    Vittorio Giovara <vittorio.giovara@gmail.com>
Committer: Vittorio Giovara <vittorio.giovara@gmail.com>
Date:      Mon Nov 17 00:22:20 2014 +0100

lavfi: clean memory on error in ADD_FORMAT()

CC: libav-stable@libav.org
Bug-Id: CID 1250334

---

 libavfilter/formats.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Patch

diff --git a/libavfilter/formats.c b/libavfilter/formats.c
index 24a4fab..ea61ed2 100644
--- a/libavfilter/formats.c
+++ b/libavfilter/formats.c
@@ -188,8 +188,10 @@  do {                                                        \
                                                             \
     fmts = av_realloc((*f)->list,                           \
                       sizeof(*(*f)->list) * ((*f)->nb + 1));\
-    if (!fmts)                                              \
+    if (!fmts) {                                            \
+        av_freep(&f);                                       \
         return AVERROR(ENOMEM);                             \
+    }                                                       \
                                                             \
     (*f)->list = fmts;                                      \
     (*f)->list[(*f)->nb++] = fmt;                           \