[03/10] configure: Default to armasm for --toolchain=msvc when targeting arm

Message ID 1437904678-19444-3-git-send-email-martin@martin.st
State Committed
Commit 2192ff84dd720968108bc1ca54e239f4c94eb61d
Headers show

Commit Message

Martin Storsjö July 26, 2015, 9:57 a.m.
---
 configure | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Luca Barbato July 26, 2015, 10:16 a.m. | #1
On 26/07/15 11:57, Martin Storsjö wrote:
> ---
>   configure | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/configure b/configure
> index 9ccd0da..96e5f93 100755
> --- a/configure
> +++ b/configure
> @@ -2642,6 +2642,11 @@ case "$toolchain" in
>           ld_default="$source_path/compat/windows/mslink"
>           nm_default="dumpbin -symbols"
>           ar_default="lib"
> +        case "$arch" in
> +        arm*)
> +            as_default="armasm"
> +            ;;
> +        esac
>           target_os_default="win32"
>           # Use a relative path for TMPDIR. This makes sure all the
>           # ffconf temp files are written with a relative path, avoiding
>

Probably ok.
Jean-Baptiste Kempf July 26, 2015, 10:59 a.m. | #2
On 26 Jul, Martin Storsjö wrote :
> ---
>  configure | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/configure b/configure
> index 9ccd0da..96e5f93 100755
> --- a/configure
> +++ b/configure
> @@ -2642,6 +2642,11 @@ case "$toolchain" in
>          ld_default="$source_path/compat/windows/mslink"
>          nm_default="dumpbin -symbols"
>          ar_default="lib"
> +        case "$arch" in
> +        arm*)
> +            as_default="armasm"
> +            ;;
> +        esac
>          target_os_default="win32"
>          # Use a relative path for TMPDIR. This makes sure all the
>          # ffconf temp files are written with a relative path, avoiding

LGTM.

With my kindest regards,
Janne Grunau July 26, 2015, 9:59 p.m. | #3
On 2015-07-26 12:57:51 +0300, Martin Storsjö wrote:
> ---
>  configure | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/configure b/configure
> index 9ccd0da..96e5f93 100755
> --- a/configure
> +++ b/configure
> @@ -2642,6 +2642,11 @@ case "$toolchain" in
>          ld_default="$source_path/compat/windows/mslink"
>          nm_default="dumpbin -symbols"
>          ar_default="lib"
> +        case "$arch" in
> +        arm*)
> +            as_default="armasm"
> +            ;;
> +        esac
>          target_os_default="win32"
>          # Use a relative path for TMPDIR. This makes sure all the
>          # ffconf temp files are written with a relative path, avoiding

ok

Janne

Patch

diff --git a/configure b/configure
index 9ccd0da..96e5f93 100755
--- a/configure
+++ b/configure
@@ -2642,6 +2642,11 @@  case "$toolchain" in
         ld_default="$source_path/compat/windows/mslink"
         nm_default="dumpbin -symbols"
         ar_default="lib"
+        case "$arch" in
+        arm*)
+            as_default="armasm"
+            ;;
+        esac
         target_os_default="win32"
         # Use a relative path for TMPDIR. This makes sure all the
         # ffconf temp files are written with a relative path, avoiding