configure: #include stdint.h as part of libxavs test

Message ID 1475651207-24855-1-git-send-email-diego@biurrun.de
State Committed
Commit 20abcaa273a6e77d0a2e1a98c643c73562c6f8f2
Headers show

Commit Message

Diego Biurrun Oct. 5, 2016, 7:06 a.m.
Unfortunately the xavs.h API header is not self-sufficient and relies
on manual stdint.h inclusion by its users.
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Janne Grunau Oct. 5, 2016, 8:33 a.m. | #1
On 2016-10-05 09:06:47 +0200, Diego Biurrun wrote:
> Unfortunately the xavs.h API header is not self-sufficient and relies
> on manual stdint.h inclusion by its users.

have you tried fixing it upstream? Not that I have high hopes of getting 
this fixed considering the last commit was over 5 years ago.

> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index fa8c958..3b8d539 100755
> --- a/configure
> +++ b/configure
> @@ -4652,7 +4652,7 @@ enabled libx264           && require_pkg_config x264 "stdint.h x264.h" x264_enco
>  enabled libx265           && require_pkg_config x265 x265.h x265_api_get &&
>                               { check_cpp_condition x265.h "X265_BUILD >= 57" ||
>                                 die "ERROR: libx265 version must be >= 57."; }
> -enabled libxavs           && require libxavs xavs.h xavs_encoder_encode -lxavs
> +enabled libxavs           && require libxavs "stdint.h xavs.h" xavs_encoder_encode -lxavs
>  enabled libxvid           && require libxvid xvid.h xvid_global -lxvidcore
>  enabled mmal              && { check_lib interface/mmal/mmal.h mmal_port_connect -lmmal_core -lmmal_util -lmmal_vc_client -lbcm_host ||
>                                  { ! enabled cross_compile && {

patch ok

Janne
Diego Biurrun Oct. 5, 2016, 8:41 a.m. | #2
On Wed, Oct 05, 2016 at 10:33:12AM +0200, Janne Grunau wrote:
> On 2016-10-05 09:06:47 +0200, Diego Biurrun wrote:
> > Unfortunately the xavs.h API header is not self-sufficient and relies
> > on manual stdint.h inclusion by its users.
> 
> have you tried fixing it upstream? Not that I have high hopes of getting 
> this fixed considering the last commit was over 5 years ago.

No, since the project looks like abandonware at this point.  Also,
they have copied this (more than dubious) decision from x264, so
it is completely intentional in a way.

Diego

Patch

diff --git a/configure b/configure
index fa8c958..3b8d539 100755
--- a/configure
+++ b/configure
@@ -4652,7 +4652,7 @@  enabled libx264           && require_pkg_config x264 "stdint.h x264.h" x264_enco
 enabled libx265           && require_pkg_config x265 x265.h x265_api_get &&
                              { check_cpp_condition x265.h "X265_BUILD >= 57" ||
                                die "ERROR: libx265 version must be >= 57."; }
-enabled libxavs           && require libxavs xavs.h xavs_encoder_encode -lxavs
+enabled libxavs           && require libxavs "stdint.h xavs.h" xavs_encoder_encode -lxavs
 enabled libxvid           && require libxvid xvid.h xvid_global -lxvidcore
 enabled mmal              && { check_lib interface/mmal/mmal.h mmal_port_connect -lmmal_core -lmmal_util -lmmal_vc_client -lbcm_host ||
                                 { ! enabled cross_compile && {