[1/4] hevc: x86: Refactor IDCT macro declarations

Message ID 1475674674-2689-1-git-send-email-diego@biurrun.de
State Committed
Commit d9dccc03890a976dba59d66ed3b5aceeaa33d14c
Headers show

Commit Message

Diego Biurrun Oct. 5, 2016, 1:37 p.m.
---
 libavcodec/x86/hevc_idct.asm | 34 +++++++++++-----------------------
 1 file changed, 11 insertions(+), 23 deletions(-)

Comments

Alexandra Hájková Oct. 6, 2016, 12:10 p.m. | #1
This's a part of my  add IDCT patch, I don't undesrtand why it's sent
under your name. Also I see this's already pushed without any review.
I strongly dislike your behaviour and I don't understand why are you
doing this.
Diego Biurrun Oct. 6, 2016, 1:18 p.m. | #2
On Thu, Oct 06, 2016 at 02:10:02PM +0200, Alexandra Hájková wrote:
> This's a part of my  add IDCT patch, I don't undesrtand why it's sent
> under your name.

It's an independent refactoring of existing code that I did and applied
your patch on top.

> Also I see this's already pushed without any review.

I previously sent it as part of a 2-part set:

  Date: Wed,  5 Oct 2016 11:49:50 +0200
  Subject: [libav-devel] [PATCH 1/2] hevc: x86: Refactor IDCT macro declarations
  Message-Id: <1475660991-2406-1-git-send-email-diego@biurrun.de>

Luca OKed it here:

  Date: Wed, 5 Oct 2016 13:08:22 +0200
  Subject: Re: [libav-devel] [PATCH 1/2] hevc: x86: Refactor IDCT macro declarations
  Message-ID: <09ef3f7a-889b-880b-7740-0edb08a23873@gentoo.org>

I pushed it after the standard 24-hour grace period had passed.

Diego

Patch

diff --git a/libavcodec/x86/hevc_idct.asm b/libavcodec/x86/hevc_idct.asm
index d662aa9..71e4607 100644
--- a/libavcodec/x86/hevc_idct.asm
+++ b/libavcodec/x86/hevc_idct.asm
@@ -74,34 +74,22 @@  cglobal hevc_idct_%1x%1_dc_%2, 1, 2, 1, coeff, tmp
     RET
 %endmacro
 
-; 8-bit
+%macro INIT_IDCT_DC 1
 INIT_MMX mmxext
-IDCT_DC_NL  4,      8
-IDCT_DC     8,  2,  8
+IDCT_DC_NL  4,      %1
+IDCT_DC     8,  2,  %1
 
 INIT_XMM sse2
-IDCT_DC_NL  8,      8
-IDCT_DC    16,  4,  8
-IDCT_DC    32, 16,  8
+IDCT_DC_NL  8,      %1
+IDCT_DC    16,  4,  %1
+IDCT_DC    32, 16,  %1
 
 %if HAVE_AVX2_EXTERNAL
 INIT_YMM avx2
-IDCT_DC    16,  2,  8
-IDCT_DC    32,  8,  8
+IDCT_DC    16,  2,  %1
+IDCT_DC    32,  8,  %1
 %endif ;HAVE_AVX2_EXTERNAL
+%endmacro
 
-; 10-bit
-INIT_MMX mmxext
-IDCT_DC_NL  4,     10
-IDCT_DC     8,  2, 10
-
-INIT_XMM sse2
-IDCT_DC_NL  8,     10
-IDCT_DC    16,  4, 10
-IDCT_DC    32, 16, 10
-
-%if HAVE_AVX2_EXTERNAL
-INIT_YMM avx2
-IDCT_DC    16,  2, 10
-IDCT_DC    32,  8, 10
-%endif ;HAVE_AVX2_EXTERNAL
+INIT_IDCT_DC  8
+INIT_IDCT_DC 10