[4/5] rtmpproto: Don't include the libavformat version as "clientid"

Message ID 20161014133843.11941-4-martin@martin.st
State Committed
Commit 9f23f77a532ca9c2b7dc4b5328bc413e4f6f5b56
Headers show

Commit Message

Martin Storsjö Oct. 14, 2016, 1:38 p.m.
When acting as server, the server can include a "clientid" property
in some status messages. But this should be a unique number
identifying the client session, not identifying the server itself.
In practice, omitting it works just as well as including this
incorrect field.
---
 libavformat/rtmpproto.c | 3 ---
 1 file changed, 3 deletions(-)

Patch

diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c
index 4107b46..0097841 100644
--- a/libavformat/rtmpproto.c
+++ b/libavformat/rtmpproto.c
@@ -1874,9 +1874,6 @@  static int write_status(URLContext *s, RTMPPacket *pkt,
     ff_amf_write_string(&pp, statusmsg);
     ff_amf_write_field_name(&pp, "details");
     ff_amf_write_string(&pp, filename);
-    ff_amf_write_field_name(&pp, "clientid");
-    snprintf(statusmsg, sizeof(statusmsg), "%s", LIBAVFORMAT_IDENT);
-    ff_amf_write_string(&pp, statusmsg);
     ff_amf_write_object_end(&pp);
 
     spkt.size = pp - spkt.data;