[3/3] aarch64: h264idct: Use the offset parameter to movrel

Message ID 1478685650-22827-3-git-send-email-martin@martin.st
State Committed
Commit 6a62795d4051f435a9a2c59395d96913693922f8
Headers show

Commit Message

Martin Storsjö Nov. 9, 2016, 10 a.m.
---
 libavcodec/aarch64/h264idct_neon.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Janne Grunau Nov. 10, 2016, 8:39 a.m. | #1
On 2016-11-09 12:00:50 +0200, Martin Storsjö wrote:
> ---
>  libavcodec/aarch64/h264idct_neon.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/aarch64/h264idct_neon.S b/libavcodec/aarch64/h264idct_neon.S
> index ee23977..1c43c1f 100644
> --- a/libavcodec/aarch64/h264idct_neon.S
> +++ b/libavcodec/aarch64/h264idct_neon.S
> @@ -162,7 +162,7 @@ function ff_h264_idct_add8_neon, export=1
>          mov             w19, w3                 // stride
>          movrel          x13, X(ff_h264_idct_dc_add_neon)
>          movrel          x14, X(ff_h264_idct_add_neon)
> -        movrel          x7,  scan8+16
> +        movrel          x7,  scan8, 16
>          mov             x10, #0
>          mov             x11, #16
>  1:      mov             w2,  w19

I guess it clearer and more consistant to always handle the offset this 
way

patch ok

Janne

Patch

diff --git a/libavcodec/aarch64/h264idct_neon.S b/libavcodec/aarch64/h264idct_neon.S
index ee23977..1c43c1f 100644
--- a/libavcodec/aarch64/h264idct_neon.S
+++ b/libavcodec/aarch64/h264idct_neon.S
@@ -162,7 +162,7 @@  function ff_h264_idct_add8_neon, export=1
         mov             w19, w3                 // stride
         movrel          x13, X(ff_h264_idct_dc_add_neon)
         movrel          x14, X(ff_h264_idct_add_neon)
-        movrel          x7,  scan8+16
+        movrel          x7,  scan8, 16
         mov             x10, #0
         mov             x11, #16
 1:      mov             w2,  w19