[1/2] Revert "checkasm: vp9dsp: Benchmark the dc-only version of idct_idct separately"

Message ID 1479470225-28455-1-git-send-email-martin@martin.st
State Committed
Commit effc1430b2fe5997d9d55bf28dc507c27125eb27
Headers show

Commit Message

Martin Storsjö Nov. 18, 2016, 11:57 a.m.
This reverts commit 81d7f0bbca837afda1f7e60d3ae52ab1360ab44b.

Instead of just benchmarking dc separately, test all relevant subparts.
---
 tests/checkasm/vp9dsp.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Janne Grunau Nov. 18, 2016, 8:43 p.m. | #1
On 2016-11-18 13:57:04 +0200, Martin Storsjö wrote:
> This reverts commit 81d7f0bbca837afda1f7e60d3ae52ab1360ab44b.
> 
> Instead of just benchmarking dc separately, test all relevant subparts.
> ---
>  tests/checkasm/vp9dsp.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/tests/checkasm/vp9dsp.c b/tests/checkasm/vp9dsp.c
> index b9d1c73..690e0cf 100644
> --- a/tests/checkasm/vp9dsp.c
> +++ b/tests/checkasm/vp9dsp.c
> @@ -297,12 +297,6 @@ static void check_itxfm(void)
>                  }
>                  bench_new(dst, sz * SIZEOF_PIXEL, coef, sz * sz);
>              }
> -            if (txtp == 0 && tx != 4) {
> -                if (check_func(dsp.itxfm_add[tx][txtp], "vp9_inv_%s_%dx%d_dc_add",
> -                               txtp_types[txtp], sz, sz)) {
> -                    bench_new(dst, sz * SIZEOF_PIXEL, coef, 1);
> -                }
> -            }
>          }
>      }
>      report("itxfm");

ok once I understand patch 2/2

Janne
> -- 
> 2.7.4
> 
> _______________________________________________
> libav-devel mailing list
> libav-devel@libav.org
> https://lists.libav.org/mailman/listinfo/libav-devel

Patch

diff --git a/tests/checkasm/vp9dsp.c b/tests/checkasm/vp9dsp.c
index b9d1c73..690e0cf 100644
--- a/tests/checkasm/vp9dsp.c
+++ b/tests/checkasm/vp9dsp.c
@@ -297,12 +297,6 @@  static void check_itxfm(void)
                 }
                 bench_new(dst, sz * SIZEOF_PIXEL, coef, sz * sz);
             }
-            if (txtp == 0 && tx != 4) {
-                if (check_func(dsp.itxfm_add[tx][txtp], "vp9_inv_%s_%dx%d_dc_add",
-                               txtp_types[txtp], sz, sz)) {
-                    bench_new(dst, sz * SIZEOF_PIXEL, coef, 1);
-                }
-            }
         }
     }
     report("itxfm");