fate.sh: Allow setting other make flags for running tests

Message ID 20161122201009.91460-1-martin@martin.st
State Committed
Headers show

Commit Message

Martin Storsjö Nov. 22, 2016, 8:10 p.m.
If makeopts_fate is set, these makeopts are used for running the
tests instead of the normal makeopts. If it isn't set, the normal
makeopts variable is used as before.

This is useful if remote testing on a lesser machine where a large
number of parallel jobs might be undesireable, while wanting to speed
up the build with many parallel processes.
---
 tests/fate.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Luca Barbato Nov. 23, 2016, 3:36 a.m. | #1
On 22/11/2016 21:10, Martin Storsjö wrote:
> If makeopts_fate is set, these makeopts are used for running the
> tests instead of the normal makeopts. If it isn't set, the normal
> makeopts variable is used as before.
> 
> This is useful if remote testing on a lesser machine where a large
> number of parallel jobs might be undesireable, while wanting to speed
> up the build with many parallel processes.
> ---
>  tests/fate.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/fate.sh b/tests/fate.sh
> index b8ee1ae..f7ca891 100755
> --- a/tests/fate.sh
> +++ b/tests/fate.sh
> @@ -73,7 +73,7 @@ compile()(
>  fate()(
>      test "$build_only" = "yes" && return
>      cd ${build} || return
> -    ${make} ${makeopts} -k fate
> +    ${make} ${makeopts_fate-${makeopts}} -k fate
>  )
>  
>  clean(){
> 

Sounds useful :)
Diego Biurrun Nov. 23, 2016, 7:16 a.m. | #2
On Tue, Nov 22, 2016 at 10:10:09PM +0200, Martin Storsjö wrote:
> If makeopts_fate is set, these makeopts are used for running the
> tests instead of the normal makeopts. If it isn't set, the normal
> makeopts variable is used as before.
> 
> This is useful if remote testing on a lesser machine where a large
> number of parallel jobs might be undesireable, while wanting to speed
> up the build with many parallel processes.
> ---
>  tests/fate.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Please add this, commented-out, to the example config file in doc/fate.texi.

LGTM otherwise.

Diego

Patch

diff --git a/tests/fate.sh b/tests/fate.sh
index b8ee1ae..f7ca891 100755
--- a/tests/fate.sh
+++ b/tests/fate.sh
@@ -73,7 +73,7 @@  compile()(
 fate()(
     test "$build_only" = "yes" && return
     cd ${build} || return
-    ${make} ${makeopts} -k fate
+    ${make} ${makeopts_fate-${makeopts}} -k fate
 )
 
 clean(){