configure: Add quotes around a variable which might be empty

Message ID 20170125131248.28782-1-martin@martin.st
State Committed
Commit f96d07f4ec4193fb5293d7ac8f1324aac3c3ea07
Headers show

Commit Message

Martin Storsjö Jan. 25, 2017, 1:12 p.m.
If we only have a target compiler but no host compiler, the $type
variable will be empty once.

(Currently we fail to do a cross build if no host compiler is available
due to using the host compiler for processing option lists though.
But despite that, this comparison in configure needs quotes.)
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Diego Biurrun Jan. 25, 2017, 2:30 p.m. | #1
On Wed, Jan 25, 2017 at 03:12:48PM +0200, Martin Storsjö wrote:
> If we only have a target compiler but no host compiler, the $type
> variable will be empty once.
> 
> (Currently we fail to do a cross build if no host compiler is available
> due to using the host compiler for processing option lists though.
> But despite that, this comparison in configure needs quotes.)
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

OK

Diego

Patch

diff --git a/configure b/configure
index f186753..7570c0a 100755
--- a/configure
+++ b/configure
@@ -5033,7 +5033,7 @@  fi
 for pfx in "" host_; do
     varname=${pfx%_}cc_type
     eval "type=\$$varname"
-    if [ $type = "msvc" ]; then
+    if [ "$type" = "msvc" ]; then
         check_${pfx}cc <<EOF || add_${pfx}cflags -Dinline=__inline
 static inline int foo(int a) { return a; }
 EOF