[1/6] arm: vp9itxfm: Share instructions for loading idct coeffs in the 8x8 function

Message ID 1486643401-4732-1-git-send-email-martin@martin.st
State Committed
Commit 3933b86bb93aca47f29fbd493075b0f110c1e3f5
Headers show

Commit Message

Martin Storsjö Feb. 9, 2017, 12:29 p.m.
---
 libavcodec/arm/vp9itxfm_neon.S | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Janne Grunau Feb. 9, 2017, 6:40 p.m. | #1
On 2017-02-09 14:29:56 +0200, Martin Storsjö wrote:
> ---
>  libavcodec/arm/vp9itxfm_neon.S | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/libavcodec/arm/vp9itxfm_neon.S b/libavcodec/arm/vp9itxfm_neon.S
> index 167d517..3d0b0fa 100644
> --- a/libavcodec/arm/vp9itxfm_neon.S
> +++ b/libavcodec/arm/vp9itxfm_neon.S
> @@ -412,13 +412,12 @@ function ff_vp9_\txfm1\()_\txfm2\()_8x8_add_neon, export=1
>  .ifc \txfm1\()_\txfm2,idct_idct
>          movrel          r12, idct_coeffs
>          vpush           {q4-q5}
> -        vld1.16         {q0}, [r12,:128]
>  .else
>          movrel          r12, iadst8_coeffs
>          vld1.16         {q1}, [r12,:128]!
>          vpush           {q4-q7}
> -        vld1.16         {q0}, [r12,:128]
>  .endif
> +        vld1.16         {q0}, [r12,:128]
>  
>          vmov.i16        q2, #0
>          vmov.i16        q3, #0

the whole set is ok

Janne

Patch

diff --git a/libavcodec/arm/vp9itxfm_neon.S b/libavcodec/arm/vp9itxfm_neon.S
index 167d517..3d0b0fa 100644
--- a/libavcodec/arm/vp9itxfm_neon.S
+++ b/libavcodec/arm/vp9itxfm_neon.S
@@ -412,13 +412,12 @@  function ff_vp9_\txfm1\()_\txfm2\()_8x8_add_neon, export=1
 .ifc \txfm1\()_\txfm2,idct_idct
         movrel          r12, idct_coeffs
         vpush           {q4-q5}
-        vld1.16         {q0}, [r12,:128]
 .else
         movrel          r12, iadst8_coeffs
         vld1.16         {q1}, [r12,:128]!
         vpush           {q4-q7}
-        vld1.16         {q0}, [r12,:128]
 .endif
+        vld1.16         {q0}, [r12,:128]
 
         vmov.i16        q2, #0
         vmov.i16        q3, #0