[5/5] Revert "fate: Skip the checkasm test if CONFIG_STATIC is disabled"
diff mbox

Message ID 1503647204-20460-5-git-send-email-martin@martin.st
State Committed
Commit 39e16ee2289e4240a82597b97db5541bbbd2b996
Headers show

Commit Message

Martin Storsjö Aug. 25, 2017, 7:46 a.m. 
When we use dllexport properly for shared libraries on windows,
there's no longer any issue with linking the object files for
e.g. libavcodec statically into checkasm. (It's still not possible
to link the built object files for e.g. libavformat statically to
libavcodec though, since libavformat exepcts to load av_export_*
symbols from a DLL.)

This reverts commit 4e62b57ee03928c12a3119dcaf78ffa1f4d6985f.
---
 tests/fate/checkasm.mak | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Luca Barbato Aug. 26, 2017, 12:09 a.m. | #1 
On 25/08/2017 09:46, Martin Storsjö wrote:
> When we use dllexport properly for shared libraries on windows,
> there's no longer any issue with linking the object files for
> e.g. libavcodec statically into checkasm. (It's still not possible
> to link the built object files for e.g. libavformat statically to
> libavcodec though, since libavformat exepcts to load av_export_*
> symbols from a DLL.)
> 
> This reverts commit 4e62b57ee03928c12a3119dcaf78ffa1f4d6985f.
> ---
>   tests/fate/checkasm.mak | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/fate/checkasm.mak b/tests/fate/checkasm.mak
> index 5721f1f..939eb56 100644
> --- a/tests/fate/checkasm.mak
> +++ b/tests/fate/checkasm.mak
> @@ -19,5 +19,5 @@ $(FATE_CHECKASM): tests/checkasm/checkasm$(EXESUF)
>   $(FATE_CHECKASM): CMD = run tests/checkasm/checkasm --test=$(@:fate-checkasm-%=%)
>   $(FATE_CHECKASM): REF = /dev/null
>   
> -FATE-$(CONFIG_STATIC) += $(FATE_CHECKASM)
> +FATE += $(FATE_CHECKASM)
>   fate-checkasm: $(FATE_CHECKASM)
> 

Ok.

Patch
diff mbox 

diff --git a/tests/fate/checkasm.mak b/tests/fate/checkasm.mak
index 5721f1f..939eb56 100644
--- a/tests/fate/checkasm.mak
+++ b/tests/fate/checkasm.mak
@@ -19,5 +19,5 @@  $(FATE_CHECKASM): tests/checkasm/checkasm$(EXESUF)
 $(FATE_CHECKASM): CMD = run tests/checkasm/checkasm --test=$(@:fate-checkasm-%=%)
 $(FATE_CHECKASM): REF = /dev/null
 
-FATE-$(CONFIG_STATIC) += $(FATE_CHECKASM)
+FATE += $(FATE_CHECKASM)
 fate-checkasm: $(FATE_CHECKASM)