Makefile: fix distclean target

Message ID 20171113203430.8-1-jamrial@gmail.com
State New
Headers show

Commit Message

James Almer Nov. 13, 2017, 8:34 p.m.
It must imply clean. Regression since 7ebe7e8e7a76c0ce302f4f583ef0d14220031214.

Signed-off-by: James Almer <jamrial@gmail.com>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Diego Biurrun Nov. 13, 2017, 10:56 p.m. | #1
On Mon, Nov 13, 2017 at 05:34:30PM -0300, James Almer wrote:
> It must imply clean. Regression since 7ebe7e8e7a76c0ce302f4f583ef0d14220031214.
> 
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

All my mistakes he finds.. :)

> --- a/Makefile
> +++ b/Makefile
> @@ -171,7 +171,7 @@ clean::
>  
> -distclean::
> +distclean:: clean

Drop the unnecessary double colon while you're at it.

OK

Diego

Patch

diff --git a/Makefile b/Makefile
index 5f91294c8e..024d59f815 100644
--- a/Makefile
+++ b/Makefile
@@ -171,7 +171,7 @@  clean::
 	$(RM) $(addprefix compat/,$(CLEANSUFFIXES)) $(addprefix compat/*/,$(CLEANSUFFIXES))
 	$(RM) -rf coverage.info lcov
 
-distclean::
+distclean:: clean
 	$(RM) .version avversion.h config.asm config.h mapfile \
             avbuild/.config avbuild/config.* libavutil/avconfig.h \
             libavcodec/bsf_list.c libavformat/protocol_list.c