[GASPP,1/3] Document what versions were buggy and required GASPP_ARMASM64_INVERT_SCALE

Message ID 1520326712-19031-1-git-send-email-martin@martin.st
State Committed
Headers show
Series
  • [GASPP,1/3] Document what versions were buggy and required GASPP_ARMASM64_INVERT_SCALE
Related show

Commit Message

Martin Storsjö March 6, 2018, 8:58 a.m.
---
 gas-preprocessor.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Luca Barbato March 6, 2018, 2:02 p.m. | #1
Set ok.
Janne Grunau March 14, 2018, 9:54 p.m. | #2
On 2018-03-06 10:58:30 +0200, Martin Storsjö wrote:
> ---
>  gas-preprocessor.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl
> index 3787756..9ff47a9 100755
> --- a/gas-preprocessor.pl
> +++ b/gas-preprocessor.pl
> @@ -1041,7 +1041,7 @@ sub handle_serialized_line {
>              if ($ENV{GASPP_ARMASM64_INVERT_SCALE}) {
>                  # Instructions like fcvtzs and scvtf store the scale value
>                  # inverted in the opcode (stored as 64 - scale), but armasm64
> -                # in early versions stores it as-is. Thus convert from
> +                # in VS < 15.5 stores it as-is. Thus convert from
>                  # "fcvtzs w0, s0, #8" into "fcvtzs w0, s0, #56".
>                  if ($line =~ /(?:fcvtzs|scvtf)\s+(\w+)\s*,\s*(\w+)\s*,\s*#(\d+)/) {
>                      my $scale = $3;

ok

Janne

Patch

diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl
index 3787756..9ff47a9 100755
--- a/gas-preprocessor.pl
+++ b/gas-preprocessor.pl
@@ -1041,7 +1041,7 @@  sub handle_serialized_line {
             if ($ENV{GASPP_ARMASM64_INVERT_SCALE}) {
                 # Instructions like fcvtzs and scvtf store the scale value
                 # inverted in the opcode (stored as 64 - scale), but armasm64
-                # in early versions stores it as-is. Thus convert from
+                # in VS < 15.5 stores it as-is. Thus convert from
                 # "fcvtzs w0, s0, #8" into "fcvtzs w0, s0, #56".
                 if ($line =~ /(?:fcvtzs|scvtf)\s+(\w+)\s*,\s*(\w+)\s*,\s*#(\d+)/) {
                     my $scale = $3;