x86: Don't declare a non-static function as inline

Message ID 1523734826-8076-1-git-send-email-martin@martin.st
State Committed
Commit 347aa8f72356124ec6b95bf8ebd1faf72db03f8d
Headers show
Series
  • x86: Don't declare a non-static function as inline
Related show

Commit Message

Martin Storsjö April 14, 2018, 7:40 p.m.
This fixes building with clang in msvc mode, which does support
gcc style inline assembly.
---
 libavcodec/x86/xvididct_sse2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Diego Biurrun April 15, 2018, 1:45 p.m. | #1
On Sat, Apr 14, 2018 at 10:40:26PM +0300, Martin Storsjö wrote:
> This fixes building with clang in msvc mode, which does support
> gcc style inline assembly.
> ---
>  libavcodec/x86/xvididct_sse2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

probably OK

Diego

Patch

diff --git a/libavcodec/x86/xvididct_sse2.c b/libavcodec/x86/xvididct_sse2.c
index f318e95..0de59a5 100644
--- a/libavcodec/x86/xvididct_sse2.c
+++ b/libavcodec/x86/xvididct_sse2.c
@@ -342,7 +342,7 @@  DECLARE_ASM_CONST(16, int32_t, walkenIdctRounders)[] = {
     "movdqa   %%xmm6, 4*16("dct")     \n\t" \
     "movdqa   "SREG2", 7*16("dct")    \n\t"
 
-inline void ff_xvid_idct_sse2(short *block)
+void ff_xvid_idct_sse2(short *block)
 {
     __asm__ volatile (
         "movq     "MANGLE (m127) ", %%mm0                              \n\t"