[02/20] tests: Enable CRC test for yuv4mpeg

Message ID 20180920084729.4523-3-diego@biurrun.de
State New
Headers show
Series
  • [01/20] tests: Use more consistent names for tests
Related show

Commit Message

Diego Biurrun Sept. 20, 2018, 8:47 a.m.
---
 tests/lavf-regression.sh | 2 +-
 tests/ref/lavf/y4m       | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

Comments

Vittorio Giovara Sept. 20, 2018, 11:29 a.m. | #1
On Thu, Sep 20, 2018 at 10:47 AM, Diego Biurrun <diego@biurrun.de> wrote:

> ---
>  tests/lavf-regression.sh | 2 +-
>  tests/ref/lavf/y4m       | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/lavf-regression.sh b/tests/lavf-regression.sh
> index 18f000bbea..fc9869cb9d 100755
> --- a/tests/lavf-regression.sh
> +++ b/tests/lavf-regression.sh
> @@ -130,7 +130,7 @@ fi
>  if [ -n "$do_y4m" ] ; then
>  file=${outfile}lavf.$test
>  do_avconv $file $DEC_OPTS -f image2 -c:v pgmyuv -i $raw_src $ENC_OPTS -t
> 1 -qscale 10
> -#do_avconv_crc $file -i $target_path/$file
> +do_avconv_crc $file -i $target_path/$file
>  fi
>
>  # image formats
> diff --git a/tests/ref/lavf/y4m b/tests/ref/lavf/y4m
> index 8c1566ea0d..367b37621d 100644
> --- a/tests/ref/lavf/y4m
> +++ b/tests/ref/lavf/y4m
> @@ -1,2 +1,3 @@
>  ec8178cb152f9cdbfd9cb724d977db2e *./tests/data/lavf/lavf.y4m
>  3801808 ./tests/data/lavf/lavf.y4m
> +./tests/data/lavf/lavf.y4m CRC=0x0a941f26
> --


OK. Do you know why it was disabled?
Diego Biurrun Sept. 20, 2018, 11:52 a.m. | #2
On Thu, Sep 20, 2018 at 01:29:01PM +0200, Vittorio Giovara wrote:
> On Thu, Sep 20, 2018 at 10:47 AM, Diego Biurrun <diego@biurrun.de> wrote:
> > --- a/tests/lavf-regression.sh
> > +++ b/tests/lavf-regression.sh
> > @@ -130,7 +130,7 @@ fi
> >  if [ -n "$do_y4m" ] ; then
> >  file=${outfile}lavf.$test
> >  do_avconv $file $DEC_OPTS -f image2 -c:v pgmyuv -i $raw_src $ENC_OPTS -t
> > 1 -qscale 10
> > -#do_avconv_crc $file -i $target_path/$file
> > +do_avconv_crc $file -i $target_path/$file
> >  fi
> >
> > --- a/tests/ref/lavf/y4m
> > +++ b/tests/ref/lavf/y4m
> > @@ -1,2 +1,3 @@
> >  ec8178cb152f9cdbfd9cb724d977db2e *./tests/data/lavf/lavf.y4m
> >  3801808 ./tests/data/lavf/lavf.y4m
> > +./tests/data/lavf/lavf.y4m CRC=0x0a941f26
> 
> OK. Do you know why it was disabled?

It was added disabled back in 2003. I think it passed oracle the last time
around. Notice that the also-disabled lavf-rm CRC test is broken, it gives
different results on many configurations.

Diego

Patch

diff --git a/tests/lavf-regression.sh b/tests/lavf-regression.sh
index 18f000bbea..fc9869cb9d 100755
--- a/tests/lavf-regression.sh
+++ b/tests/lavf-regression.sh
@@ -130,7 +130,7 @@  fi
 if [ -n "$do_y4m" ] ; then
 file=${outfile}lavf.$test
 do_avconv $file $DEC_OPTS -f image2 -c:v pgmyuv -i $raw_src $ENC_OPTS -t 1 -qscale 10
-#do_avconv_crc $file -i $target_path/$file
+do_avconv_crc $file -i $target_path/$file
 fi
 
 # image formats
diff --git a/tests/ref/lavf/y4m b/tests/ref/lavf/y4m
index 8c1566ea0d..367b37621d 100644
--- a/tests/ref/lavf/y4m
+++ b/tests/ref/lavf/y4m
@@ -1,2 +1,3 @@ 
 ec8178cb152f9cdbfd9cb724d977db2e *./tests/data/lavf/lavf.y4m
 3801808 ./tests/data/lavf/lavf.y4m
+./tests/data/lavf/lavf.y4m CRC=0x0a941f26