From patchwork Fri Jan 11 13:24:19 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: arm: Create proper .rdata sections for COFF X-Patchwork-Submitter: =?utf-8?q?Martin_Storsj=C3=B6?= X-Patchwork-Id: 64409 Message-Id: <20190111132419.56467-1-martin@martin.st> To: libav-devel@libav.org Cc: Tom Tan Date: Fri, 11 Jan 2019 15:24:19 +0200 From: =?utf-8?q?Martin_Storsj=C3=B6?= List-Id: libav development As .rodata isn't one of the default created sections for COFF, it was created as a read-write data section. By using the default .rdata section name for COFF, it automatically becomes a read-only data section. The existing ".section .rodata" works as intended for ELF though. This is based on an original patch and diagnose by Tom Tan . --- libavutil/aarch64/asm.S | 2 ++ libavutil/arm/asm.S | 2 ++ 2 files changed, 4 insertions(+) diff --git a/libavutil/aarch64/asm.S b/libavutil/aarch64/asm.S index 15b55d57d2..bf5c1b7ee1 100644 --- a/libavutil/aarch64/asm.S +++ b/libavutil/aarch64/asm.S @@ -63,6 +63,8 @@ ELF .size \name, . - \name .else .section .rodata .endif +#elif defined(_WIN32) + .section .rdata #elif !defined(__MACH__) .section .rodata #else diff --git a/libavutil/arm/asm.S b/libavutil/arm/asm.S index 62ce493180..9842d03bc0 100644 --- a/libavutil/arm/asm.S +++ b/libavutil/arm/asm.S @@ -125,6 +125,8 @@ ELF .size \name, . - \name .else .section .rodata .endif +#elif defined(_WIN32) + .section .rdata #elif !defined(__MACH__) .section .rodata #else